Skip to content

Studio: clarify llama.cpp update banner copy#6313

Merged
danielhanchen merged 1 commit into
mainfrom
studio-llama-banner-copy
Jun 14, 2026
Merged

Studio: clarify llama.cpp update banner copy#6313
danielhanchen merged 1 commit into
mainfrom
studio-llama-banner-copy

Conversation

@danielhanchen

Copy link
Copy Markdown
Member

Summary

  • Rename the update banner heading from "New llama.cpp version" to "New llama.cpp update".
  • Add a small hint under the version line, "Updating will not need a restart", so it is clear that applying the update is non-disruptive.

Notes

Copy-only change in studio/frontend/src/components/llama-update-banner.tsx; no behavior change. The applying-state label ("Updating llama.cpp...") is unchanged.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the LlamaUpdateBanner component by changing the header text to 'New llama.cpp update' and adding a helper message indicating that a restart is not required. The reviewer suggested conditionally rendering this helper message only when the update is not currently in progress to avoid redundancy and optimize vertical space.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment on lines +183 to +185
<p className="mt-1 text-[11px] text-muted-foreground/70">
Updating will not need a restart
</p>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The reassurance hint "Updating will not need a restart" is useful for helping the user decide to initiate the update. Once the update is already in progress (applying is true), this text is redundant and takes up vertical space. Consider conditionally rendering it only when the update is not yet in progress.

{!applying && (
                  <p className="mt-1 text-[11px] text-muted-foreground/70">
                    Updating will not need a restart
                  </p>
                )}

Rename the banner heading from "New llama.cpp version" to "New llama.cpp
update", and add a small hint under the version line ("No restart needed
after update"). Tighten the gap above the action row so the hint and the
buttons read as one group.
@danielhanchen danielhanchen force-pushed the studio-llama-banner-copy branch from 5daf41c to 4b13db4 Compare June 14, 2026 09:43
@danielhanchen danielhanchen merged commit 19ae073 into main Jun 14, 2026
34 checks passed
@danielhanchen danielhanchen deleted the studio-llama-banner-copy branch June 14, 2026 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant