Refactor code to make it more amenable to cross compilation#150
Merged
Conversation
Also cleanup some of it
Owner
|
Plus one from me. Could you add an example in the docs or maybe even a test of a cross compilation? Cross compiling to WebAssembly should work because that's built into the compiler. Do any of the compilers in Yggdrasil provide cross compilation? |
Contributor
Author
|
Yggy has tons of cross compilers, but they only run in linux. |
Collaborator
|
Cool! We should make sure we're being consistent about |
MasonProtter
approved these changes
Dec 5, 2023
MasonProtter
left a comment
MasonProtter
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me. Would you mind bumping the major version and then I think this is ready to go. Fixes for nightly can be done later once the interfaces and such in nightly stabilize a bit.
Owner
|
Sorry. No one pulled the trigger here. Anything else we need to do here? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also cleanup some of it.
This doesn't allow for actual cross-compilation because we need the compilers, and implementing that is basically implementing BinaryBuilder, but maybe we should add an option to pass
cc.