docs(charts): mark ChartsV2 ARCHITECTURE as proposed/not-yet-implemented (#556)#718
Open
gitcommit90 wants to merge 1 commit into
Open
docs(charts): mark ChartsV2 ARCHITECTURE as proposed/not-yet-implemented (#556)#718gitcommit90 wants to merge 1 commit into
gitcommit90 wants to merge 1 commit into
Conversation
The ChartsV2/ directory contains only ARCHITECTURE.md; none of the modules, hooks, components, files, or tests it describes exist in the source tree, and ChartsV2 is not exported or referenced anywhere. The present-tense wording made the document read as if the code already existed, confusing contributors. Add a prominent status banner marking it PROPOSED/PLANNED, point readers to the current Recharts-based Charts/ implementation, and reword the overview to target/intended behavior. Closes thesysdev#556
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #556