chore(cli): define error actionability taxonomy#5775
Conversation
Supabase CLI previewnpx --yes https://pkg.pr.new/supabase/cli/supabase@2dfad1158f0f4d33f2223a39a32093e63d73c304Preview package for commit |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 511b9e3b61
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 786bba4590
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
786bba4 to
b26bfe6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b26bfe6b63
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
b26bfe6 to
b8a178b
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b8a178ba4f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
b8a178b to
8809e4c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8809e4c704
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
8809e4c to
d9f5099
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d9f509914d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
d9f5099 to
bfe8271
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bfe8271f0c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
bfe8271 to
0aa23a6
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0aa23a6145
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
0aa23a6 to
32045e5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32045e5fb8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
32045e5 to
d3c25fe
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d3c25fe0e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
d3c25fe to
99b1f00
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 99b1f00ac5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
99b1f00 to
6e3a70a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e3a70af06
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
6e3a70a to
fec1bae
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fec1bae011
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
fec1bae to
003c29d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 003c29dd8e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
003c29d to
4fc9f35
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4fc9f35a67
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
4fc9f35 to
0b91f42
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b91f42490
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
0b91f42 to
cbcb7e0
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cbcb7e01f7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
cbcb7e0 to
8577e5c
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8577e5c649
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
8577e5c to
afc01d5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afc01d54d6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
afc01d5 to
4be05e0
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4be05e02aa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
4be05e0 to
37efe38
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 37efe38abf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
37efe38 to
650a763
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 650a763799
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
650a763 to
7097e17
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7097e17c48
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
7097e17 to
6fa7002
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6fa7002bfa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
6fa7002 to
ae7c3f2
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ae7c3f2068
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jgoux
force-pushed
the
julien/cli-1560-define-cli-error-actionability-taxonomy
branch
from
ae7c3f2 to
2dfad11
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2dfad1158f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "LegacyExperimentalRequiredError", | ||
| "LegacyInvalidOutputFormatError", |
There was a problem hiding this comment.
When a legacy experimental command is run without --experimental (for example supabase storage cp ...) or a command-specific -o value is rejected (for example supabase backups list -o table), these tags are raised before withLegacyCommandInstrumentation; the comments/tests around legacyRequireExperimental and legacyValidateOutputFormat explicitly require no cli_command_executed event to match Go. Whitelisting them here makes the outer runCli failure handler emit a root telemetry event anyway, so those parse/pre-run rejects are now counted in command failure metrics despite the handler instrumentation intentionally suppressing them.
Useful? React with 👍 / 👎.
| "LegacySeedMutuallyExclusiveFlagsError", | ||
| "LegacyStorageMutuallyExclusiveFlagsError", | ||
| "MissingOption", | ||
| "ProjectEnvParseError", |
There was a problem hiding this comment.
This pre-handler allowlist includes malformed project env files but still omits ProjectConfigParseError. start.command.ts loads supabase/config.toml in its Command.provide callback before withCommandInstrumentation runs, so a malformed config (for example during supabase start) exits through the outer handler without any cli_command_executed failure event even though the taxonomy already maps that tag as invalid config.
Useful? React with 👍 / 👎.
| } | ||
|
|
||
| export function commandNameForRootTelemetry(args: ReadonlyArray<string>): string { | ||
| const commandPath = extractCommandPath(args); |
There was a problem hiding this comment.
For pre-handler parser failures invoked through the legacy alias, such as supabase migrations list --bad, extractCommandPath returns migrations ..., but the whitelist only contains the canonical migration ... paths. Successful executions use the canonical commandRuntimeLayer(["migration", ...]), so alias parse failures are attributed to root instead of joining the migration command metrics unless this path is normalized before matching.
Useful? React with 👍 / 👎.
| return Effect.gen(function* () { | ||
| if (!shouldCapturePreHandlerFailureTelemetry(cause)) return; | ||
|
|
||
| const analytics = yield* Analytics; |
There was a problem hiding this comment.
When a project .env is malformed, the command fails with ProjectEnvParseError and this helper now tries to emit pre-handler telemetry, but acquiring Analytics depends on CliConfig/ProjectContext and re-runs the same failing env parse. Because the capture is not best-effort, that second failure aborts before output.fail(...) and the final processControl.exit(...), so these user-fixable parse errors can lose the normalized CLI error output without producing the telemetry event either.
Useful? React with 👍 / 👎.
1 participant
Defines the CLI error actionability taxonomy for KPI reporting and adds a sanitized classifier contract for future
cli_command_executedfailure metadata.This keeps the Q2 recovery and repeat definitions close to the telemetry catalog, while preserving the current behavior that command events only emit existing fields until the follow-up instrumentation issue wires classification into capture.