NodeMaterial: Dynamically copy properties in copy()#33775
Merged
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
WestLangley
reviewed
Jun 12, 2026
Collaborator
Author
|
/cc @brunosimon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: N/A
Description
This PR refactors
NodeMaterial.copy()to dynamically copy properties instead of relying on a hardcoded list of node property assignments.The new implementation ensures compatibility by verifying that a property is defined on both the source and the target before copying, also ignoring common properties like
is*,uuid,id, and private properties.Currently the code below does not work.
The defaults values currently are defined procedurally, the PR #28328 improve this, but it's require major changes.
The copying process honors nested
.copy()calls for properties that implement them (such asColororVector2), ensuring that sub-object values are properly copied instead of just overwriting references and additionally, it deep-copiesuserDataand clones individual elements inside theclippingPlanesarray.