Conversation
Only assign the transmission, sheen, clearcoat and anisotropy node inputs when the MaterialX graph actually provides them. Assigning a `float( 0 )` default set the corresponding material node, which forced that lobe to compile into the shader even when unused. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Owner
Author
|
@bhouston FYI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The loader assigned
float( 0 )defaults totransmissionNode,sheenNode,clearcoatNodeandanisotropyNode, which (via theuse*getters) forced every material to compile those lobes — even ones that don't use them. Now they're only assigned when the MaterialX graph provides them.Tested with
webgpu_loader_materialx: ~14.3 ms → ~11.0 ms GPU/frame (~23%), no visual change.