Skip to content

Inspector: Added storage settings and info feature#33571

Merged
sunag merged 7 commits into
mrdoob:devfrom
sunag:dev-inspector-settings-storage
May 17, 2026
Merged

Inspector: Added storage settings and info feature#33571
sunag merged 7 commits into
mrdoob:devfrom
sunag:dev-inspector-settings-storage

Conversation

@sunag

@sunag sunag commented May 14, 2026

Copy link
Copy Markdown
Collaborator

Related issue: #33559 (comment)

Description

  • Added storage settings for URL Session or Keep across Origin, using URL Session as default.
  • Added Clear Settings button.
image

/cc @mrdoob @WestLangley

@sunag sunag added this to the r185 milestone May 14, 2026
@sunag sunag marked this pull request as ready for review May 14, 2026 03:00
@WestLangley

Copy link
Copy Markdown
Collaborator

Maybe a simple checkbox is sufficient, defaulting to un-checked: "Set as Default for all Examples".

@sunag

sunag commented May 14, 2026

Copy link
Copy Markdown
Collaborator Author

Maybe a simple checkbox is sufficient, defaulting to un-checked: "Set as Default for all Examples".

I understand that "Set as Default for all Examples" seems simpler, but I think the more technical term might be broader; Inspector is designed to be used outside the scope of examples as well.

@WestLangley

Copy link
Copy Markdown
Collaborator

I think the more technical term might be broader

How about a checkbox: "Set as Default for all Domains".

@sunag

sunag commented May 15, 2026

Copy link
Copy Markdown
Collaborator Author

How about a checkbox: "Set as Default for all Domains".

I think it is not possible to define localStorage for all domains. I think the lack of information in the names caused a misinterpretation, so I had the idea of adding an info button to provide more detailed information about the options.

image

There was a difference between origin and domain and I thought localStorage was stored by domain, so I updated it to be more accurate too.

@sunag sunag changed the title Inspector: Added storage settings Inspector: Added storage settings and info May 15, 2026
@sunag sunag changed the title Inspector: Added storage settings and info Inspector: Added storage settings and info feature May 15, 2026
@sunag sunag merged commit aeb668f into mrdoob:dev May 17, 2026
13 of 14 checks passed
@sunag sunag deleted the dev-inspector-settings-storage branch May 17, 2026 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants