improve width() performance#181
Merged
Merged
Conversation
Merging this PR will improve performance by 58.63%
Performance Changes
Comparing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #181 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 592 597 +5
Branches 142 145 +3
=========================================
+ Hits 592 597 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance improvement for most strings that are longer and contain escape sequences.
The "long loop" is only necessary to measure "cursor extent" for horizontal sequences and control character ('\b') -- we can use performance-optimized version if such sequences are detected as not found.
This does however have a negative effect of measuring VS-16 and ZWJ-related "glitch" sequences, which is no problem, wcwidth makes no guarantees of their measured length, but its worth writing negative test case to verify these conditions in future changes.