reset deterministic in tearDownClass#11785
Merged
Merged
Conversation
yao-matrix
approved these changes
Jun 24, 2025
Contributor
Author
|
Hi @sayakpaul . Could you please review it? Thanks! |
sayakpaul
approved these changes
Jun 24, 2025
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
Contributor
Author
|
Hi @sayakpaul . Please let me know if anything needs to be changed before merging. Thanks! |
sayakpaul
approved these changes
Jul 1, 2025
Member
|
Thanks for your contributions! |
tolgacangoz
pushed a commit
to tolgacangoz/diffusers
that referenced
this pull request
Jul 5, 2025
* reset deterministic in tearDownClass Signed-off-by: jiqing-feng <jiqing.feng@intel.com> * fix deterministic setting Signed-off-by: jiqing-feng <jiqing.feng@intel.com> --------- Signed-off-by: jiqing-feng <jiqing.feng@intel.com> Co-authored-by: Sayak Paul <spsayakpaul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #11738 , we enabled deterministic but forgot to reset it to False. Setting deterministic to False in tearDownClass will make the deterministic only have impacts for the test class and won't influence other tests.