Multi container registry support#185
Draft
mxey wants to merge 3 commits into
Draft
Conversation
Centralize most of the logic for getting an auth token and adding it to the request in preparation for supporting container registries without authentication.
Docker Hub remains the only implemented registry, but this allows it to work with registry.k8s.io. Ideally the authURL would not be hardcoded per registry but be discovered from the registry's response headers.
Author
|
@andrew This already works for registry.k8s.io because it requires no authentication. I haven't added any tests or configuration yet, but is this a general direction you'd accept? Also CONTRIBUTING.md didn't say whether you prefer multi-commit PRs or stacked PRs. |
Author
|
The auth parts of this might have to change depending on #186 |
|
I found @kpfleming approach of making it configurable much better: |
Author
|
@markkrj Do you mean just the fact that it's configurable? As I said in my initial PR description, configuration is still missing. This is a prototype to gather feedback on the basic idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #56
Open issues:
registry.k8s.io/kube-apiserverbecomescache/artifacts/oci/kube-apiserver