Support token-cmd on Windows#131
Merged
Merged
Conversation
execValue now runs the command via %COMSPEC% /c on Windows instead of returning an error, so token-cmd works on all platforms. Tests updated to use portable commands (exit 1 instead of false, %FORGE_DOMAIN% for the env-var expansion test on Windows). Fixes the windows-latest CI job which has been failing since #124.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #124 added
token-cmdbut returned an error on Windows since it shells out viash -c. The tests for the happy path weren't skipped there, sowindows-latesthas been red on main since it merged (visible on the dependabot PRs).Rather than skip the tests, run the command via
%COMSPEC% /con Windows sotoken-cmdworks everywhere. Tests now use portable commands (exit 1instead offalse,%FORGE_DOMAIN%for the env-var expansion check on Windows). README and--token-cmdflag help updated to drop the Unix-only caveat.