feat(discover): remove transactions and surface errors#119062
feat(discover): remove transactions and surface errors#119062nikkikapadia wants to merge 4 commits into
Conversation
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| path: `/${discoverPath}/`, | ||
| organization, | ||
| }); | ||
| return <Redirect to={targetPath + location.search} />; |
There was a problem hiding this comment.
Discover redirect mangles pathname
High Severity
For orgs with discover-saved-queries-deprecation, bookmarks or links under /explore/discover/ are rewritten by stripping /explore/discover/ then calling replaceAll('/', '') on the full pathname. That removes the org segment and every slash, so makeDiscoverPathname gets garbage like /organizationsacmeresults/ instead of /results/.
Reviewed by Cursor Bugbot for commit 50ff58a. Configure here.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1c34048. Configure here.
| return <Redirect to={targetPath + location.search} />; | ||
| } | ||
| // transactions dataset redirects to traces url as we don't support transactions anymore | ||
| return <Redirect to={normalizeUrl('/explore/traces/')} />; |
There was a problem hiding this comment.
Transaction redirect drops query
Medium Severity
The transactions-dataset deprecation redirect sends users to traces with only normalizeUrl('/explore/traces/') and does not append location.search, unlike the errors-dataset branch which keeps query parameters via targetPath + location.search.
Reviewed by Cursor Bugbot for commit 1c34048. Configure here.
1 participant
i've changed the urls in a few different places and the WIP errors product to a different temporary url so it's easy to distinguish. I've also done some styling and title adjustments in the sidebar, page header, and cmd-k menu. I've also implemented the correct redirects.
Work to be done in future PRs:
what it's looking like now (please ignore the other errors menu item no one else sees this besides a few data browsing members)
