feat(spans): add option to rollout process_segment task#119003
Conversation
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f4f5e66. Configure here.
| len(message["spans"]), | ||
| ) | ||
| if produce_to_process_segment_task: | ||
| task_produce_future = process_segment_task.apply_async_with_future( |
There was a problem hiding this comment.
i think the rollout should happen within the produce() function, but this can also be cleaned up later when the rollout flag is gone
There was a problem hiding this comment.
I agree, I think it's cleaner like that.
There was a problem hiding this comment.
there isn't a really clean way to have the rollout decision be in the produce() function and be per-segment at the same time, I'll just clean them up later when removing the rollout flag
lvthanh03
force-pushed
the
tony/rollout-task-segment
branch
from
c3a7b36 to
87047ac
Compare
2 participants
Refs STREAM-1308
Adds a rollout path for the spans buffer flusher to enqueue flushed segments directly to the
process_segmenttask.When
spans.buffer.process-segments-task-rollout-rateis enabled, segment bytes are sent to the new task instead of being produced to thebuffered-segmentstopic.