Skip to content

fix(tracemetrics): Add validation for single equation for timeseries#117568

Merged
narsaynorath merged 4 commits into
masterfrom
nar/fix/tracemetrics-dashboards-validation-for-equations
Jun 15, 2026
Merged

fix(tracemetrics): Add validation for single equation for timeseries#117568
narsaynorath merged 4 commits into
masterfrom
nar/fix/tracemetrics-dashboards-validation-for-equations

Conversation

@narsaynorath

Copy link
Copy Markdown
Member

Metrics widgets should not be allowed to be created if they are timeseries and have an equation, with more than one aggregate. We restrict the UI to just showing the equation, so it's necessary that there are no other aggregates

@narsaynorath narsaynorath requested a review from a team as a code owner June 12, 2026 19:52
@narsaynorath narsaynorath requested a review from a team June 12, 2026 19:52
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 12, 2026
Comment thread src/sentry/api/serializers/rest_framework/dashboard.py Outdated
Comment thread src/sentry/api/serializers/rest_framework/dashboard.py Outdated

@adrianviquez adrianviquez left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment + approved

@narsaynorath narsaynorath merged commit 864087e into master Jun 15, 2026
66 checks passed
@narsaynorath narsaynorath deleted the nar/fix/tracemetrics-dashboards-validation-for-equations branch June 15, 2026 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants