Skip to content

feat(api): Accept project slugs in product integration endpoints#117495

Merged
gricha merged 6 commits into
masterfrom
feat/project-id-or-slug-product-integrations
Jun 15, 2026
Merged

feat(api): Accept project slugs in product integration endpoints#117495
gricha merged 6 commits into
masterfrom
feat/project-id-or-slug-product-integrations

Conversation

@gricha

@gricha gricha commented Jun 12, 2026

Copy link
Copy Markdown
Member

Code mapping bulk operations, monitor creation, notification actions, and preprod latest-base snapshot lookup now accept project IDs or slugs where those surfaces already accepted project identifiers. The changes keep existing permission checks, preserve existing projectSlug runtime/schema compatibility, and document canonical project/projects values as ID-or-slug without adding new projectSlug OpenAPI parameters.

This is the product integrations split from the project ID-or-slug migration stack and targets the resolver branch for independent review. Validated with focused product endpoint tests, targeted ruff, git diff --check, and make test-api-docs.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 12, 2026
Base automatically changed from feat/project-id-or-slug-resolver to master June 12, 2026 18:50
@gricha gricha force-pushed the feat/project-id-or-slug-product-integrations branch from 0eea84c to fa25a83 Compare June 12, 2026 18:53
gricha and others added 3 commits June 12, 2026 15:02
Allow code mappings, monitors, notification actions, and preprod snapshot lookups to resolve project inputs by ID or slug while keeping legacy projectSlug runtime support.

Co-Authored-By: OpenCode <noreply@opencode.ai>
Keep the existing preprod latest-base projectSlug query metadata while documenting project as the canonical ID-or-slug query parameter.

Co-Authored-By: OpenCode <noreply@opencode.ai>
Use the shared integer-or-string schema for the preprod latest-base project filter so generated clients can keep passing numeric project IDs.

Co-Authored-By: OpenCode <noreply@opencode.ai>
@gricha gricha force-pushed the feat/project-id-or-slug-product-integrations branch from fa25a83 to 3b703a7 Compare June 12, 2026 22:03
Use direct ID-or-slug branching for single-project lookups instead of the bulk project parser. This keeps sentinel rejection and permission behavior unchanged while making the control flow easier to read.

Co-Authored-By: OpenCode <opencode@users.noreply.github.com>
@gricha gricha marked this pull request as ready for review June 12, 2026 22:11
@gricha gricha requested review from a team as code owners June 12, 2026 22:11

@JoshFerge JoshFerge left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we not do more of this logic in the OrganizationEndpoint base?

Move single-project ID-or-slug parsing into OrganizationEndpoint so endpoints share projectSlug precedence, blank handling, and all-project sentinel rejection.

Keep endpoint-specific project existence and queryset behavior at the call sites.

Co-Authored-By: OpenCode <opencode@users.noreply.github.com>
@gricha gricha requested a review from a team as a code owner June 15, 2026 16:32
@gricha gricha enabled auto-merge (squash) June 15, 2026 18:08
@gricha gricha merged commit 25b4622 into master Jun 15, 2026
85 of 86 checks passed
@gricha gricha deleted the feat/project-id-or-slug-product-integrations branch June 15, 2026 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants