Skip to content

fix(seer): navigate same-origin markdown links with the router#117432

Merged
natemoo-re merged 3 commits into
masterfrom
nm/seer/link-navigate
Jun 11, 2026
Merged

fix(seer): navigate same-origin markdown links with the router#117432
natemoo-re merged 3 commits into
masterfrom
nm/seer/link-navigate

Conversation

@natemoo-re

Copy link
Copy Markdown
Member

The LLM sends fully resolved URLs like https://sentry.sentry.io/issues/ABC-123/ in its markdown responses. The <Markdown> component's DefaultLink treats these as external (they don't match the /^\/[^/]/ internal pattern), so every link renders as <ExternalLink> with target="_blank" — opening in a new tab even on plain click.

toRelativeHref strips the origin when the link points at the current app, so DefaultLink sees a relative path and uses the router <Link> instead.

@natemoo-re natemoo-re requested a review from a team as a code owner June 11, 2026 17:29
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 11, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 4a277c953dae2af813d75388c79658d1d8aaf1da. Configure here.

Comment thread static/app/views/seerExplorer/components/chat/shared.tsx
Comment thread static/app/views/seerExplorer/components/chat/shared.tsx
@natemoo-re natemoo-re enabled auto-merge (squash) June 11, 2026 17:49
@natemoo-re natemoo-re merged commit c7d39bc into master Jun 11, 2026
76 checks passed
@natemoo-re natemoo-re deleted the nm/seer/link-navigate branch June 11, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants