fix(seer): Fix an issue where the Autofix Agent filter wasnt working properly#117381
Conversation
…properly Before this fix the filter was incorrectly filtering projects using what is now called `seerAgentIntegrationsSelectQueryOptions`. It should instead filter by provider-name, or the new seerAgentProviderSelectQueryOptions list of options. The difference is `cursor_background_agent:1234` vs. `cursor_background_agent`. We want to filter by provider name, not including integration_id, so that it works better as integrations are rotated.
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 676fb86. Configure here.
| <Flex gap="md" wrap="wrap"> | ||
| {agentSelectOptions.length ? ( | ||
| <CompactSelect<'all' | AutofixAgentSelectOption> | ||
| <CompactSelect |
There was a problem hiding this comment.
Agent filter hidden while loading
Medium Severity
The agent filter is only rendered when agentSelectOptions.length is truthy, but that list now defaults to [] while the integrations query is pending or failed. The previous hook always included at least the Seer option immediately, so the filter could disappear during load and stay hidden if the integrations request errors.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 676fb86. Configure here.
There was a problem hiding this comment.
there are async loading problems, but i'm not replicating issues very easily.
if something fails to load the page will be messed up in a lot of ways. it's hard to be graceful to just one of these requests.
| ...(knownAgents ?? []) | ||
| .filter(i => isPreferredAgentProvider(i.provider)) | ||
| ...selectAgentIntegrations(data) | ||
| .filter(i => isPreferredAgentProvider(i.provider)) // filter out copilot, it cannot be saved. |
There was a problem hiding this comment.
different operating mode
| * Builds on `knownAgentIntegrationsQueryOptions` and overrides `select` to | ||
| * produce `{value, label}` tuples filtered to preferred-agent integration ids. | ||
| */ | ||
| export function seerAgentIntegrationsSelectQueryOptions({ |
There was a problem hiding this comment.
might be help to explain the difference between this and seerAgentProviderSelectQueryOptions
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
…tIntegrationsSelectQueryOptions some more
…tential provider-name options
2 participants
Before this fix the filter was incorrectly filtering projects using what is now called
seerAgentIntegrationsSelectQueryOptions. It should instead filter by provider-name, or the new seerAgentProviderSelectQueryOptions list of options.The difference is
cursor_background_agent:1234vs.cursor_background_agent. We want to filter by provider name, not including integration_id, so that it works better as instances are created/removedBefore
The query param was
?agent=claude_code_agent::380236After
The query param is
?agent=claude_code_agentResults are found