fix(seer-explorer): Key tool-call rows by id, not function+index#117365
Merged
Conversation
The React key was `${toolCall.function}-${idx}` — index-based and not unique
when a block has two calls to the same tool (duplicate keys). Tool-call ids are
now non-null and stable over the wire (getsentry/seer#6887 synthesizes one when
the provider omits it), so key on the id directly.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Zylphrex
approved these changes
Jun 10, 2026
…null ToolCall.id is typed nullable on the frontend, and the non-null guarantee only holds once getsentry/seer#6887 is deployed. Fall back to the prior key so the list is safe regardless of deploy order; when id is present it's unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The React key for tool-call rows was
${toolCall.function}-${idx}— index-based (the classic anti-pattern) and not unique when a block makes two calls to the same tool, which produces duplicate keys and can mis-reconcile renders.Key on
toolCall.idinstead. Tool-call ids are now non-null and stable across polls over the wire — getsentry/seer#6887 synthesizes a deterministicseer:{block_id}:{index}id when the provider (e.g. Gemini) omits one — so the id is safe to use as the key.Best landed after/with getsentry/seer#6887, which guarantees the non-null stable id.