ref(integrations): Remove the legacy popup install flow#117364
Merged
evanpurkhiser merged 1 commit intoJun 10, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
Contributor
📊 Type Coverage Diff
🔍 2 new type safety issues introducedType assertions (
This is informational only and does not block the PR. |
Now that every integration provider installs through the API-driven pipeline modal, drop the legacy popup-window flow from `useAddIntegration`: the `window.open` setup dialog, the `message` event listener that awaited its postMessage result, and the `UNCONDITIONAL_API_PIPELINE_PROVIDERS` / `API_PIPELINE_FEATURE_FLAGS` gating that chose between the two paths. `startFlow` now always opens the pipeline modal. Also removes the dead plumbing this exposed: the `modalParams`/`use_staging` and `account` params that only fed the popup, and the now-unused `computeCenteredWindow` helper.
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-integrations-remove-the-legacy-popup-install-flow
branch
from
64b4abb to
e1b242b
Compare
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
evanpurkhiser
deleted the
evanpurkhiser/ref-integrations-remove-the-legacy-popup-install-flow
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that every integration provider installs through the API-driven pipeline modal, drop the legacy popup-window flow from
useAddIntegration: thewindow.opensetup dialog, themessageevent listener that awaited its postMessage result, and theUNCONDITIONAL_API_PIPELINE_PROVIDERS/API_PIPELINE_FEATURE_FLAGSgating that chose between the two paths.startFlownow always opens the pipeline modal.Also removes the dead plumbing this exposed: the
modalParams/use_stagingandaccountparams that only fed the popup, and the now-unusedcomputeCenteredWindowhelper.Part of VDY-32.