feat(seer): Populate SeerAgentRun.group from the client's group#117314
Merged
Conversation
SeerAgentRun.group was declared but never written: start_run only passed project, and the SeerAgentClient had no way to receive a group. Autofix identified the issue to Seer solely via category_value and a hand-built metadata group_id, leaving the mirror column always NULL. Add a typed group param to SeerAgentClient (sibling of project) so the column is populated on run creation, and source group_id in the Seer metadata payload from that field instead of hand-threading it in autofix. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
Member
Author
|
@sentry review |
trevor-e
added
the
Trigger: getsentry tests
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SeerAgentRun.groupwas declared but never written.start_runonly passedproject, andSeerAgentClienthad no way to receive a group, so the mirror column was always NULL. Autofix communicated the issue to Seer solely throughcategory_valueand a hand-builtmetadatagroup_id.SeerAgentClientnow takes a typedgroupparam (sibling ofproject) that populates the column on run creation.Single source for group_id
start_runinjectsgroup_idinto the Seer metadata payload fromself.group, mirroring howproject_idis injected fromself.project. Autofix no longer hand-builds{"group_id": group.id}— it passesgroup=grouponce, which feeds both the column and the Seer metadata.Explorer chat, night-shift triage (spans many candidate groups), and the read-only
get_autofix_agent_statecorrectly leave the column NULL.