feat(explore): Check attribute key and name for hidden values#117304
Merged
nsdeschenes merged 2 commits intoJun 10, 2026
Conversation
Number attributes are returned keyed by their explicit form (e.g. `tags[project_id,number]`) while displaying the base name (`project_id`), which is what the hidden field lists contain. removeHiddenKeys only compared the raw key, so these attributes leaked into the logs search query builder, group by dropdown, and visualize dropdown even though the hidden constants were passed through. Match the column editor's behaviour by also excluding an attribute when its display name is in the hidden list. Refs EXP-991 Co-Authored-By: Claude <noreply@anthropic.com>
The type-to-search autocomplete fetch in useGetTraceItemAttributeTagKeys filtered hidden keys by the raw attribute key only. Explicitly-typed keys such as `tags[project_id,number]` have a display name (`project_id`) that is what the hidden lists contain, so the keys still surfaced as suggestions in the logs search query builder. Also exclude a fetched key when its display name is in the hidden list, matching removeHiddenKeys and the column editor. Refs EXP-991 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
Author
|
@sentry review |
Contributor
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0f86ccb. Configure here.
nikkikapadia
approved these changes
Jun 10, 2026
nsdeschenes
deleted the
nd/EXP-991/feat-explore-respect-hidden-attribute-consts
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tweaks the logic for how we check for hidden attributes to check both the key and name, as we were missing the removal of some.
Closes EXP-991