ref(pr-metrics): Remove PullRequestAttribution REFERENCED_ISSUE from pull_request path#117284
Merged
giovanni-guidini merged 1 commit intoJun 10, 2026
Merged
Conversation
…pull_request path Drop the REFERENCED_ISSUE attribution branch from handle_attribution. The webhook no longer parses PR body/title to find Sentry issues; that signal will come from GroupLink instead. Removes the _refresh_referenced_issue_attribution and _description_changed helpers, the _REFERENCED_ISSUE_ATTRIBUTION_ACTIONS constant, the now-unused PullRequestAttribution / ReferencedIssueSignalDetails imports, and the orphaned pr_metrics/types.py module. Cleans up all related tests. Refs CORE-235 Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
vaind
approved these changes
Jun 10, 2026
giovanni-guidini
deleted the
gio/core-235-remove-referenced-issue-attribution
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the
REFERENCED_ISSUEattribution branch fromhandle_attribution. The webhook handler no longer parses PR body/title to find referenced Sentry issues; that signal will be derived fromGroupLinkinstead (per CORE-235).Concretely:
_REFERENCED_ISSUE_ATTRIBUTION_ACTIONSconstant and the block inhandle_attributionthat called_refresh_referenced_issue_attribution_refresh_referenced_issue_attributionand_description_changedPullRequestAttribution,ReferencedIssueSignalDetails,find_referenced_groups) and the orphanedpr_metrics/types.pymoduletest_irrelevant_actions_skippedto includereopenedandedited(now truly no-ops for attribution)Refs CORE-235
Given we don't yet have the judge path wired in, and we already incldue the group_ids via GroupLinks in the emitted event we should be OK dropping this now.