ref: Remove barely used tabs prop from SettingsPageHeader#117266
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
scttcper
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes an extra
<div style={{flex: 1}}>wrapper that wasn't doing anything.Maybe we can say that it was helping to order tabs so they're in the correct position at the bottom under the subtitle/action.... but only 4 of 100 instances were using this. IMO it's not being helpful.
What i really want to target is the required marginBottom under the subtitle/action.. now that these tabs are out of the way that could be easier.