Skip to content

fix(apps): Fix theme issues with a divider#117231

Merged
ryan953 merged 1 commit into
getsentry:masterfrom
Asynchronite:fix/external-app-theme
Jun 10, 2026
Merged

fix(apps): Fix theme issues with a divider#117231
ryan953 merged 1 commit into
getsentry:masterfrom
Asynchronite:fix/external-app-theme

Conversation

@Asynchronite

Copy link
Copy Markdown
Contributor

Fixes theme issues with a divider inside the sentryAppDetailsModal which used a static white color for its border. Basically replace it with the theme-aware p.theme.tokens.border.secondary to reflect this change.

Closes #112440.

Starting to get active with contributing here, so I'm taking small tasks here and there that I don't see anyone else working on

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

…lsModal` which used a static white color for its border. Basically replace it with the theme-aware `p.theme.tokens.border.secondary` to reflect this change.

Fixes getsentry#112440.
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 9, 2026
@rodolfoBee rodolfoBee requested a review from a team June 10, 2026 09:28
@nsdeschenes nsdeschenes requested a review from a team June 10, 2026 10:48
@aldy505 aldy505 added the Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests label Jun 10, 2026
@ryan953 ryan953 merged commit da149b1 into getsentry:master Jun 10, 2026
74 of 77 checks passed
@Asynchronite Asynchronite deleted the fix/external-app-theme branch June 11, 2026 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components Trigger: getsentry tests Once code is reviewed: apply label to PR to trigger getsentry tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

external-install: divider line uses light-mode color in dark mode

3 participants