fix(tracemetrics): Switching to equation mode clears aliases#117229
Merged
narsaynorath merged 2 commits intoJun 10, 2026
Merged
fix(tracemetrics): Switching to equation mode clears aliases#117229narsaynorath merged 2 commits into
narsaynorath merged 2 commits into
Conversation
We don't support aliases yet for equations mode, so clear them when switching. They are cached in the series mode so when flipped back, they will still apply.
github-actions
Bot
added
the
Scope: Frontend
adrianviquez
approved these changes
Jun 10, 2026
adrianviquez
left a comment
adrianviquez
left a comment
Contributor
There was a problem hiding this comment.
Lgtm! Is there an easy way to properly toggle/untoggle the series/equation mode for the test so we don't have to mock the navigate?
Member
Author
@adrianviquez good call, the navigate call was the easiest thing to mock so we just did that since it's a side effect of updating the widget builder state, but I updated the test to just check the final alias state without checking the navigation. I think I'll update the rest of the tests to use a similar pattern afterwards |
narsaynorath
deleted the
nar/fix/tracemetrics-widget-builder-doesnt-clear-aliases
branch
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't support aliases yet for equations mode, so clear them when switching. They are cached in the series mode so when flipped back, they will still apply.