Skip to content

ref(ACI): Remove workflow_status_update_handler and use generic handler#117152

Merged
saponifi3d merged 8 commits into
masterfrom
jcallender/aci/generic-activity-handler
Jun 9, 2026
Merged

ref(ACI): Remove workflow_status_update_handler and use generic handler#117152
saponifi3d merged 8 commits into
masterfrom
jcallender/aci/generic-activity-handler

Conversation

@saponifi3d

Copy link
Copy Markdown
Contributor

Description

Create a generic activity_handler handler for activity updates. This will allow us to have a single hook for activities, but for now it will only handle the resolved activities.

This should also fix the issue where only metric issues were getting a resolution case, as this is a more generic call site.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 9, 2026
@saponifi3d saponifi3d force-pushed the jcallender/aci/generic-activity-handler branch from 3e76482 to caad713 Compare June 9, 2026 20:07
@saponifi3d saponifi3d marked this pull request as ready for review June 9, 2026 20:32
@saponifi3d saponifi3d requested a review from a team as a code owner June 9, 2026 20:32
@saponifi3d saponifi3d force-pushed the jcallender/aci/seer-activity-handler-update branch from fdcdd2a to d8f1efe Compare June 9, 2026 20:33
@saponifi3d saponifi3d force-pushed the jcallender/aci/generic-activity-handler branch from 9e10913 to 44f9d1f Compare June 9, 2026 20:33
Comment thread src/sentry/workflow_engine/handlers/workflow/__init__.py
]

# Activity types handled by the generic activity_handler. This replaces the
# group_status_update_registry path (see workflow_status_update_handler) once the

@Christinarlong Christinarlong Jun 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the goal to get rid of group_status_update_registry? If so, I'm curious why? I'm not familiar with the original purpose of the registry so prob. missing context here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep! that's the goal. (the next PR in the stack, remove status handler, will do that if you're curious what that will look like).

there are two main reasons:

  1. the way the group_status_update_registry works right now is that it will read from the kafka consumer, then trigger for activities. unfortunately, only metric issues really create activities like this. that means that if a SET_RESOLVED activity happens on a cron issue, it won't trigger workflow engine or send notifications to users about that resolution. The generic handler based on the activity (instead of the status change message) will be triggered for all those missing activities 🎉

  2. there are two different registries for more or less 1 code path, we want to trigger the process_workflow_activity method. This will allow us to reduce the total number of registries. Since the group_status_update_registry was more different than the desired goal, i decided to give that one the chop instead of the seer one.

Base automatically changed from jcallender/aci/seer-activity-handler-update to master June 9, 2026 21:41
@saponifi3d saponifi3d requested review from a team as code owners June 9, 2026 21:41
@saponifi3d saponifi3d force-pushed the jcallender/aci/generic-activity-handler branch from 6300c50 to 43f6aeb Compare June 9, 2026 21:45
@saponifi3d saponifi3d force-pushed the jcallender/aci/generic-activity-handler branch from 43f6aeb to c37be85 Compare June 9, 2026 22:03
@saponifi3d saponifi3d requested review from a team as code owners June 9, 2026 22:12
@saponifi3d saponifi3d merged commit b86cf64 into master Jun 9, 2026
84 checks passed
@saponifi3d saponifi3d deleted the jcallender/aci/generic-activity-handler branch June 9, 2026 22:33
@owen-sheppard

Copy link
Copy Markdown

I'm trying to use the uptime monitor and am not receiving a resolved webhook. Is this issue fixed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants