ref(ACI): Remove workflow_status_update_handler and use generic handler#117152
Conversation
3e76482 to
caad713
Compare
fdcdd2a to
d8f1efe
Compare
9e10913 to
44f9d1f
Compare
| ] | ||
|
|
||
| # Activity types handled by the generic activity_handler. This replaces the | ||
| # group_status_update_registry path (see workflow_status_update_handler) once the |
There was a problem hiding this comment.
is the goal to get rid of group_status_update_registry? If so, I'm curious why? I'm not familiar with the original purpose of the registry so prob. missing context here
There was a problem hiding this comment.
yep! that's the goal. (the next PR in the stack, remove status handler, will do that if you're curious what that will look like).
there are two main reasons:
-
the way the
group_status_update_registryworks right now is that it will read from the kafka consumer, then trigger for activities. unfortunately, only metric issues really create activities like this. that means that if a SET_RESOLVED activity happens on a cron issue, it won't trigger workflow engine or send notifications to users about that resolution. The generic handler based on the activity (instead of the status change message) will be triggered for all those missing activities 🎉 -
there are two different registries for more or less 1 code path, we want to trigger the
process_workflow_activitymethod. This will allow us to reduce the total number of registries. Since thegroup_status_update_registrywas more different than the desired goal, i decided to give that one the chop instead of the seer one.
6300c50 to
43f6aeb
Compare
…from a status update to a generic handler.
…ng to make it easier to clean up later.
…ency with the seer_activity_handler, it's better to have an explicit connection here
43f6aeb to
c37be85
Compare
|
I'm trying to use the uptime monitor and am not receiving a resolved webhook. Is this issue fixed? |
Description
Create a generic
activity_handlerhandler for activity updates. This will allow us to have a single hook for activities, but for now it will only handle the resolved activities.This should also fix the issue where only metric issues were getting a resolution case, as this is a more generic call site.