ref(api): tighten 2 more Goal #1 endpoint methods#117144
Merged
Merged
Conversation
- group_event_details.get(): 3-arm union. The stacktraceOnly query-param
path returns EventSerializerResponse (EventSerializer denylist) via
typed-variable; the normal path returns GroupEventDetailsResponse from
wrap_event_response; multiple error paths return DetailResponse. Pin
the `error_response` literal as DetailResponse so mypy reads it
correctly.
- preprod_artifact_snapshot.post(): tighten to
Response[SnapshotCreateResponseDict] | Response[DetailResponse]. The
success-path dict literal already matches the TypedDict; many
validation paths emit {"detail": ...}.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
cvxluo
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two more Goal #1 method tightenings.
group_event_details.get()→ 3-arm union:Response[GroupEventDetailsResponse] | Response[EventSerializerResponse] | Response[DetailResponse]. ThestacktraceOnlyquery-param path returns a stripped event shape (EventSerializerResponse) via the typed-variable trick —EventSerializeris denylisted, soserialize()flowsAnyand we pin the local to the typed shape. Normal path returnsGroupEventDetailsResponsefromwrap_event_response. Multiple error paths returnDetailResponse; the sharederror_responseliteral is pinned asDetailResponseso mypy reads it correctly.preprod_artifact_snapshot.post()→Response[SnapshotCreateResponseDict] | Response[DetailResponse]. The success-path dict literal already matches the TypedDict; many validation paths emit{"detail": ...}.Branch name is stale — started by probing
release_file_detailsendpoints but those haveFileResponsepaths I didn't want to touch in this PR.