feat(teams): Add avatar upload UI to team settings#117140
Merged
shashjar merged 22 commits intoJun 10, 2026
Merged
Conversation
…hashjar/update-team-serializer-to-return-avatar-data
github-actions
Bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
📊 Type Coverage Diff
🔍 2 new type safety issues introducedType assertions (
This is informational only and does not block the PR. |
…into shashjar/add-team-avatar-API-endpoint-and-photo-serving-view
…-view' into shashjar/add-avatar-upload-UI-to-team-settings
…-view' into shashjar/add-avatar-upload-UI-to-team-settings
…7137) One of multiple PRs to fix #49864. Follow-up to #117132. These endpoints were previously removed in #61633. Adds `GET/PUT /api/0/teams/{org}/{team}/avatar/` endpoints for reading and uploading team avatars. Adds a `/team-avatar/{ident}/` photo serving view for rendering avatar images. Follows the same patterns as `OrganizationAvatarEndpoint` and `OrganizationAvatarPhotoView`. Will be followed up by the frontend work to incorporate team avatars into the UI. --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Base automatically changed from
shashjar/add-team-avatar-API-endpoint-and-photo-serving-view
to
shashjar/update-team-serializer-to-return-avatar-data
June 9, 2026 17:23
markstory
reviewed
Jun 9, 2026
…into shashjar/add-avatar-upload-UI-to-team-settings
shashjar
commented
Jun 9, 2026
…into shashjar/add-avatar-upload-UI-to-team-settings
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3f0ca8e. Configure here.
Base automatically changed from
shashjar/update-team-serializer-to-return-avatar-data
to
master
June 9, 2026 21:52
shashjar
commented
Jun 9, 2026
| type === 'user' ? ( | ||
| <UserAvatar {...sharedAvatarProps} user={model as AvatarUser} /> | ||
| ) : type === 'team' ? ( | ||
| <TeamAvatar {...sharedAvatarProps} team={model as Team} /> |
Member
Author
There was a problem hiding this comment.
Will fix the type safety issues in a follow-up
scttcper
approved these changes
Jun 9, 2026
markstory
approved these changes
Jun 10, 2026
shashjar
added a commit
that referenced
this pull request
Jun 10, 2026
…on `type` (#117348) Follow-up to #117140. Refactors `AvatarChooserProps` from a single loose interface into a discriminated union on the `type` prop, so each variant pairs the correct `model` type with a correctly-typed `onSave` callback. Removes the `resp as Team` cast in team settings, since `resp` is now typed as `Team` by the union.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of multiple PRs to fix #49864.
Follow-up to #117137.
Adds the
teamtype to theAvatarChoosercomponent withTeamAvatarpreview. WiresAvatarChooserinto the team settings page between the form and "Team Administration" panel. All existing<TeamAvatar>usages (~20 sites) automatically render uploaded avatars (or continue to render the letters if no specific avatar image is uploaded).Before
After