feat(scraps): Add no-double-dollar-interpolation eslint rule#117121
Merged
Conversation
A doubled dollar sign in a styled/css template (`gap: $${theme.space.md}`)
emits a literal "$" before the interpolated value, producing an invalid CSS
declaration that the browser silently drops. It is almost always a typo for
`${...}`.
Add an autofixable rule that flags a trailing, unescaped `$` on any non-tail
quasi inside a styled/css tagged template, and fix one existing occurrence in
the MCP onboarding view.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Member
Author
|
@cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 621f7d7. Configure here.
ryan953
approved these changes
Jun 8, 2026
scttcper
approved these changes
Jun 8, 2026
Member
|
i'd note that i THINK that i saw the newer stylelint catches these. upgrading required more work than i was ready to do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
@sentry/scraps/no-double-dollar-interpolationrule with a fixer. It catches cases like this one from #117031 (comment):Since the existing code is invalid, I just removed it.