feat(cells): Add option to route org listing through control silo#117115
Merged
Conversation
Adds the `cells.use-control-org-listing` option flag. When enabled, the org listing control feature is exposed to the UI, so it can route requests to the new endpoint. This PR just registers and wires the option, no traffic is moved yet.
markstory
approved these changes
Jun 8, 2026
Comment on lines
+230
to
231
| yield "organizations:use-control-org-listing" | ||
|
|
Contributor
There was a problem hiding this comment.
Bug: The feature flag organizations:use-control-org-listing is implemented via options.get(), bypassing the standard features.has() registration pattern, which harms discoverability and maintainability.
Severity: LOW
Suggested Fix
Register organizations:use-control-org-listing as a feature in the feature manager (e.g., src/sentry/features/temporary.py) and use the standard features.has("organizations:use-control-org-listing", ...) check to expose it to the client, aligning it with existing patterns.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: src/sentry/web/client_config.py#L230-L231
Potential issue: The feature flag `organizations:use-control-org-listing` is implemented
by directly checking an option with `options.get()`. This bypasses the standard pattern
of registering features in the feature manager (e.g., in
`src/sentry/features/temporary.py` or `src/sentry/features/permanent.py`) and checking
them with `features.has()`. This architectural inconsistency makes the feature flag
undiscoverable to developers and automated tooling that rely on the feature manager for
auditing or analytics. While functionally correct, it introduces maintenance overhead
and potential for developer confusion, as it deviates from how other client-side
features are managed.
Did we get this right? 👍 / 👎 to inform future reviews.
Member
There was a problem hiding this comment.
That's ok, this isn't actually an org scoped feature.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the
cells.use-control-org-listingoption flag. When enabled, the org listing control feature is exposed to the UI, so it can route requests to the new endpoint.This PR just registers and wires the option, no traffic is moved yet.
The frontend code that uses this option is in #117116