test(preprod): Hide overlay color picker at xs in toolbar snapshot#117104
Merged
Conversation
The 'all controls' breakpoint snapshot hardcoded diffMode='split', rendering the overlay ColorPickerButton at the xs breakpoint. Production never produces this state: snapshots.tsx coerces 'split' to 'wipe' below the sm breakpoint via effectiveDiffMode, so the color picker (gated on 'split') is hidden there. Derive the mode in the snapshot the same way, so the xs baseline matches real behavior instead of an unreachable state. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
NicoHinderling
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
all controlsbreakpoint snapshot forSnapshotsToolbarhardcodeddiffMode='split', which rendered the overlayColorPickerButtonat thexsbreakpoint. Production never reaches this state, so the baseline was capturing an unreachable UI.Why the xs state was wrong
snapshots.tsxderiveseffectiveDiffMode, coercing'split'to'wipe'below thesmbreakpoint before passing the mode down. The color picker is gated ondiffMode === 'split', so in production it is hidden atxs. The snapshot skipped this coercion and showed the picker anyway.The snapshot now derives the mode the same way (
splitat/abovesm,wipebelow), so thexsbaseline matches real behavior. No production code changes;sm/mdsnapshots are unchanged.