ref(seer): Drop night shift in-process triage path#117032
Merged
Merged
Conversation
Night shift now always dispatches triage to Seer's feature-run endpoint, which pushes verdicts back via deliver_feature_result. The in-process triage path was gated behind seer.night_shift.use_feature_delivery during the cutover and is no longer needed once feature delivery is the default. Remove the option, the _run_triage_in_process branch, and the in-process-only modules (agentic_triage, triage_tools, event_formatter, issue_formatter) plus their tests. The autofix-from-verdicts behavior is covered by test_delivery.py. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Backend
chromy
approved these changes
Jun 11, 2026
JoshFerge
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Night shift now always dispatches issue triage to Seer's feature-run endpoint, which processes candidates and pushes verdicts back via
deliver_feature_result(the verdicts then mark skips and fire autofix). The in-process triage path — where Sentry ran the triage agent itself and triggered autofix inline — was kept behind theseer.night_shift.use_feature_deliveryoption during the cutover and is no longer needed now that feature delivery is the default.This removes:
seer.night_shift.use_feature_deliveryoption and theif/elsebranch inrun_night_shift_execution, so dispatch is unconditional._run_triage_in_processincron.py.agentic_triage,triage_tools,event_formatter,issue_formatter(and their tests).The autofix-from-verdicts behavior these tests exercised is already covered by
tests/sentry/seer/night_shift/test_delivery.py, so the in-process-specific cases intest_night_shift.pywere dropped and the remaining orchestration tests (eligibility, quota, candidate scoring, skip filtering) were re-pointed at the dispatch path._run_autofix_for_candidatesstays incron.py— it's still used by the delivery handler.