fix(tagstore): Skip array meta-columns in tag value paginator#117018
Merged
Conversation
Querying tag values for the array meta-columns tags.key/tags.value crashed with "TypeError: unhashable type: 'list'" in snuba.nest_groups. These columns map to themselves in the snuba column map and have no arrayjoin, so grouping by them returns an array per row, which nest_groups then uses as an unhashable dict key. They are not real tags and have no meaningful values to suggest, so short-circuit them to an empty paginator like the other non-suggestable columns (trace.*, event_id, etc.). Fixes SENTRY-5PD7 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
shruthilayaj
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes SENTRY-5PD7:
TypeError: unhashable type: 'list'.Querying tag values for the array meta-columns
tags.key/tags.valuecrashed insnuba.nest_groups. These columns map to themselves in the snuba column map and have noarrayjoin (
get_arrayjoinonly matchesexception_stacks|exception_frames|contexts), so thebackend issued a
GROUP BY tags.keyquery and snuba returned an array per row.nest_groupsthen used that list as a dict key → crash.
The trigger in production was the Seer public RPC
get_event_filter_key_values, which forwardedfilter_key="tags.key"to the tags-values endpoint, but any caller of that endpoint was affected.Fix
tags.key/tags.valueare array meta-columns, not real tags, and have no meaningful values tosuggest. They now short-circuit to an empty paginator in
get_tag_value_paginator_for_projects,using the same early-return blacklist that already handles
trace.*,event_id,timestamp, etc.Testing
test_get_tag_value_paginator_array_meta_columnsasserting both keys return[]insteadof raising.
GROUP BY tags.keycrash path) andpasses with it.
preklint clean on both files.Fixes SENTRY-5PD7