fix(suspect commits): Use release date as the upper bound for SCM-based commit filtering#117013
Merged
shashjar merged 1 commit intoJun 8, 2026
Conversation
nora-shap
approved these changes
Jun 5, 2026
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #78300.
When a group has a
first_release, usemin(release_date, group.first_seen)as the upper bound for suspect commit filtering, instead ofgroup.first_seenalone. This prevents flagging commits that were landed after the release was built, meaning that those commits could not possibly have caused the issue and therefore should not be identified as suspect commits. This logic falls back togroup.first_seenwhen no release is available/found (which matches existing behavior).The
group_first_seenparameter infind_commit_context_for_event_all_framesis renamed tocommit_date_maxto reflect the updated semantics.