Skip to content

fix(suspect commits): Use release date as the upper bound for SCM-based commit filtering#117013

Merged
shashjar merged 1 commit into
masterfrom
shashjar/use-release-date-as-upper-bound-for-SCM-based-commit-filtering
Jun 8, 2026
Merged

fix(suspect commits): Use release date as the upper bound for SCM-based commit filtering#117013
shashjar merged 1 commit into
masterfrom
shashjar/use-release-date-as-upper-bound-for-SCM-based-commit-filtering

Conversation

@shashjar

@shashjar shashjar commented Jun 5, 2026

Copy link
Copy Markdown
Member

Fixes #78300.

When a group has a first_release, use min(release_date, group.first_seen) as the upper bound for suspect commit filtering, instead of group.first_seen alone. This prevents flagging commits that were landed after the release was built, meaning that those commits could not possibly have caused the issue and therefore should not be identified as suspect commits. This logic falls back to group.first_seen when no release is available/found (which matches existing behavior).

The group_first_seen parameter in find_commit_context_for_event_all_frames is renamed to commit_date_max to reflect the updated semantics.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 5, 2026
@shashjar shashjar requested a review from a team June 5, 2026 19:24
@shashjar shashjar marked this pull request as ready for review June 5, 2026 19:25
@shashjar shashjar requested a review from a team as a code owner June 5, 2026 19:25
@shashjar shashjar removed the request for review from a team June 5, 2026 19:25
@shashjar shashjar merged commit 8bb0f0a into master Jun 8, 2026
65 checks passed
@shashjar shashjar deleted the shashjar/use-release-date-as-upper-bound-for-SCM-based-commit-filtering branch June 8, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Suspect Commits flags incorrect commits even in the presence of semver versions

2 participants