fix(smartSearchBar): Handle prototype filter keys#116999
Merged
Merged
Conversation
Use a null-prototype accumulator when collecting filter values so keys like constructor are treated as data keys. Co-authored-by: Codex GPT-5 <noreply@openai.com>
github-actions
Bot
added
the
Scope: Frontend
scttcper
changed the title
ryan953
approved these changes
Jun 5, 2026
scttcper
added a commit
that referenced
this pull request
Jun 5, 2026
Follow-up to #116999 for recent search suggestions. `__proto__:a` could still come back from recent searches, and the filter-key list treated it as a real key through object prototype lookup before the recent-filter counter tried to mutate `Object.prototype`. This uses own-property checks and a null-prototype counter so prototype-ish recent searches stay invalid like any other unknown filter key.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #116996 prevents a page crash when typing
constructor: