Skip to content

ref(seer-issue-activity) Refactor the Seer Issue Activity hook to be generic#116938

Merged
saponifi3d merged 10 commits into
masterfrom
jcallender/aci/seer-activity-handler-update
Jun 9, 2026
Merged

ref(seer-issue-activity) Refactor the Seer Issue Activity hook to be generic#116938
saponifi3d merged 10 commits into
masterfrom
jcallender/aci/seer-activity-handler-update

Conversation

@saponifi3d

@saponifi3d saponifi3d commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Description

Moves the callsite for the activity handler out of the seer operators and into a generic create_group_activity method. This method is invoked for all of the activities that we are concerned with.

Move the registry util into handlers/registry, this is to move all the circular dependency issues out of the registry.py file. This also adds the metrics to the util method, so we can get timing metrics on every handler.

An upcoming PR will migrate the status change handlers to use this generic registry.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 4, 2026
Comment thread src/sentry/workflow_engine/registry.py Outdated
Comment thread src/sentry/models/activity.py Outdated
Comment thread src/sentry/workflow_engine/registry.py Outdated
@saponifi3d saponifi3d force-pushed the jcallender/aci/seer-activity-handler-update branch from 9698b78 to 924e859 Compare June 8, 2026 23:34
@saponifi3d saponifi3d requested a review from leeandher June 8, 2026 23:45
@saponifi3d saponifi3d marked this pull request as ready for review June 8, 2026 23:45
@saponifi3d saponifi3d requested review from a team as code owners June 8, 2026 23:45
@saponifi3d saponifi3d force-pushed the jcallender/aci/seer-activity-handler-update branch from fdcdd2a to d8f1efe Compare June 9, 2026 20:33

@leeandher leeandher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great! 🚀

@hobzcalvin hobzcalvin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm new here, but looks relevant for the upcoming work around responding to seer activities!

@saponifi3d saponifi3d merged commit 695d94a into master Jun 9, 2026
84 checks passed
@saponifi3d saponifi3d deleted the jcallender/aci/seer-activity-handler-update branch June 9, 2026 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants