ref(seer-issue-activity) Refactor the Seer Issue Activity hook to be generic#116938
Merged
Conversation
9698b78 to
924e859
Compare
…te_group_activity. allowing us to centralize activity updates
…e typing as a separate PR
… add consistent tracking information here, so we can track every activity that is fired.
fdcdd2a to
d8f1efe
Compare
malwilley
approved these changes
Jun 9, 2026
hobzcalvin
approved these changes
Jun 9, 2026
hobzcalvin
left a comment
Contributor
There was a problem hiding this comment.
I'm new here, but looks relevant for the upcoming work around responding to seer activities!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the callsite for the activity handler out of the seer operators and into a generic
create_group_activitymethod. This method is invoked for all of the activities that we are concerned with.Move the registry util into handlers/registry, this is to move all the circular dependency issues out of the registry.py file. This also adds the metrics to the util method, so we can get timing metrics on every handler.
An upcoming PR will migrate the status change handlers to use this generic registry.