chore(typing): Remove sentry.search.events.datasets.filter_aliases from mypy ignore list#116937
Merged
shashjar merged 3 commits intoJun 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ec3f9c5. Configure here.
roggenkemper
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Resolves ENG-6454.
Fixes typing in
sentry.search.events.datasets.filter_aliasesand removes it from themypyignore list.Most errors stem from
SearchValue.raw_valuehaving a broad union type (str | float | datetime | Sequence[float] | Sequence[str]) while these filter functions always receive strings. Narrowed the types with validation at each point of use.Changes:
raw_valuetostrviaisinstanceinspan_is_segment_converter,semver_filter_converter,semver_package_filter_converter,semver_build_filter_converter, andspan_module_filter_converterraw_valuetostr | listinlowercase_searchandspan_status_filter_converterto handle eachraw_valueshapeNonefrombuilder.params.environmentsbefore passing toparse_releaselist[str]) tofilter_by_stageinstead ofEnvironmentobjects, matching itsSequence[str | int] | Nonesignature