Skip to content

ref(stats): Remove barMinHeight from usage chart bars#116762

Merged
priscilawebdev merged 1 commit into
masterfrom
priscilawebdev/ref/remove-usage-chart-bar-min-height
Jun 5, 2026
Merged

ref(stats): Remove barMinHeight from usage chart bars#116762
priscilawebdev merged 1 commit into
masterfrom
priscilawebdev/ref/remove-usage-chart-bar-min-height

Conversation

@priscilawebdev

@priscilawebdev priscilawebdev commented Jun 3, 2026

Copy link
Copy Markdown
Member

Remove barMinHeight: 1 from the org stats usage chart bar series.

Several bar series (accepted, accepted_stored, filtered, rate-limited, and
projected) set barMinHeight: 1, so ECharts drew a 1px sliver even when the
underlying value was 0. The tooltip still reported the real value (0), but the
persistent tiny bar was purely cosmetic and could be misread as non-zero usage.

This behaviour is confusing users, so I am dropping it

The usage chart set barMinHeight: 1 on several bar series, so ECharts
drew a 1px sliver even when the underlying value was 0. The tooltip
still reported the real value (0), but the persistent tiny bar was
purely cosmetic and misleading.

This was copied from an existing pattern without a clear reason. Drop
it so empty buckets render with no bar.

Co-Authored-By: Claude <noreply@anthropic.com>
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 3, 2026
@priscilawebdev

Copy link
Copy Markdown
Member Author

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 8723f9d. Configure here.

@priscilawebdev priscilawebdev requested a review from scttcper June 3, 2026 12:38
@priscilawebdev priscilawebdev marked this pull request as ready for review June 3, 2026 12:38
@priscilawebdev priscilawebdev requested a review from a team as a code owner June 3, 2026 12:38
@priscilawebdev priscilawebdev removed the request for review from scttcper June 3, 2026 12:47
@priscilawebdev priscilawebdev merged commit 6ffe7af into master Jun 5, 2026
79 checks passed
@priscilawebdev priscilawebdev deleted the priscilawebdev/ref/remove-usage-chart-bar-min-height branch June 5, 2026 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants