Skip to content

ref(detectors): Remove unnessary parameters and interfaces#116709

Merged
cmanallen merged 5 commits into
masterfrom
cmanallen/delete-unused-methods
Jun 2, 2026
Merged

ref(detectors): Remove unnessary parameters and interfaces#116709
cmanallen merged 5 commits into
masterfrom
cmanallen/delete-unused-methods

Conversation

@cmanallen

Copy link
Copy Markdown
Member

Removes is_creation_allowed_for_organization and is_creation_allowed_for_project. Adds a new is_creation_allowed method which accepts no arguments. This removes the unnecessary dependency on organization and project model instances.

…ed_for_project, and remove the project argument
@cmanallen cmanallen requested a review from a team as a code owner June 2, 2026 18:09
@cmanallen cmanallen requested a review from lobsterkatie June 2, 2026 18:10
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 2, 2026
Comment thread src/sentry/issue_detection/detectors/sql_injection_detector.py

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 82b7c4d. Configure here.

Comment thread src/sentry/issue_detection/detectors/n_plus_one_db_span_detector.py

@wedamija wedamija left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this was in place so that we could roll this out slowly to organizations/projects. Probably not too important since we can also control this at the issue platform level

@cmanallen cmanallen merged commit 7559e1a into master Jun 2, 2026
72 checks passed
@cmanallen cmanallen deleted the cmanallen/delete-unused-methods branch June 2, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants