fix(workflow): Fix type choices being a snapshot list of grouptype registry #116637
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e456a19. Configure here.
leeandher
approved these changes
Jun 2, 2026
| choices=list(INCLUDE_CHOICES.items()), required=False, initial="true" | ||
| ) | ||
| value = forms.ChoiceField(choices=list(TYPE_CHOICES.items())) | ||
| value = forms.ChoiceField(choices=get_type_choices) |
Contributor
Author
There was a problem hiding this comment.
honestly did not know either until I was 3 stackoverflow threads deep lol
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TYPE_CHOICES was getting populated at import time so GroupType import order changed or came after TYPE_CHOICES then they wouldn't get into the label which caused failing tests. This PR changes the populating of labels to just call get_type_choices directly and at runtime