-
-
Notifications
You must be signed in to change notification settings - Fork 475
feat(extend-app-start): [1/4] Add IAppStartExtender bridge #5605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
buenaflor
merged 6 commits into
feat/extend-app-start
from
feat/app-start-extension-core
Jul 6, 2026
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7a7d63f
feat(extend-app-start): Add IAppStartExtender bridge and SentryOptionโฆ
buenaflor 313fff1
chore(extend-app-start): Annotate NoOpAppStartExtender internal and fโฆ
buenaflor 540931a
refactor(extend-app-start): Rename finishAppStart to finishExtendedApโฆ
buenaflor b8779ca
feat(extend-app-start): Return null from getExtendedAppStartSpan whenโฆ
buenaflor a571467
test(extend-app-start): Remove NoOpAppStartExtenderTest per PR review
buenaflor e3d0cf9
fix(extend-app-start): Guard setAppStartExtender against null
buenaflor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package io.sentry; | ||
|
|
||
| import org.jetbrains.annotations.ApiStatus; | ||
| import org.jetbrains.annotations.Nullable; | ||
|
|
||
| /** | ||
| * Bridges the {@code Sentry.extendAppStart()} / {@code Sentry.finishExtendedAppStart()} / {@code | ||
| * Sentry.getExtendedAppStartSpan()} static API to the Android implementation. The default | ||
| * implementation ({@link NoOpAppStartExtender}) does nothing, so the API is a no-op on platforms | ||
| * that don't provide an app start measurement. | ||
| */ | ||
| @ApiStatus.Internal | ||
| public interface IAppStartExtender { | ||
|
|
||
| /** | ||
| * Begins extending the app start. Intended to be called from {@code Application.onCreate} right | ||
| * after SDK init. No-ops if the app start already finished, none is in progress, or it was | ||
| * already extended (first call wins). | ||
| */ | ||
| void extendAppStart(); | ||
|
|
||
| /** | ||
| * Finishes the extended app start, allowing the app start transaction to complete. No-ops if the | ||
| * app start was not extended or this was already called. | ||
| */ | ||
| void finishExtendedAppStart(); | ||
|
|
||
| /** | ||
| * Returns the active extended app start span to attach child spans to, or {@code null} when the | ||
| * app start is not currently being extended. | ||
| */ | ||
| @Nullable | ||
| ISpan getExtendedAppStartSpan(); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| package io.sentry; | ||
|
|
||
| import org.jetbrains.annotations.ApiStatus; | ||
| import org.jetbrains.annotations.NotNull; | ||
| import org.jetbrains.annotations.Nullable; | ||
|
|
||
| @ApiStatus.Internal | ||
| public final class NoOpAppStartExtender implements IAppStartExtender { | ||
|
buenaflor marked this conversation as resolved.
|
||
|
|
||
| private static final @NotNull NoOpAppStartExtender instance = new NoOpAppStartExtender(); | ||
|
|
||
| private NoOpAppStartExtender() {} | ||
|
|
||
| public static @NotNull NoOpAppStartExtender getInstance() { | ||
| return instance; | ||
| } | ||
|
|
||
| @Override | ||
| public void extendAppStart() {} | ||
|
|
||
| @Override | ||
| public void finishExtendedAppStart() {} | ||
|
|
||
| @Override | ||
| public @Nullable ISpan getExtendedAppStartSpan() { | ||
| return null; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to your PR, but I wish we had an
internalpackage where we can put things that we don't want customers to use. I know there is the@ApiStatus.Internalannotation already but I think have the package would also help organize the code better.