[nullable] Enable nullable reference types in ItemWithID.cs#11991
Draft
jonathanpeppers with Copilot wants to merge 3 commits into
Draft
[nullable] Enable nullable reference types in ItemWithID.cs#11991jonathanpeppers with Copilot wants to merge 3 commits into
ItemWithID.cs#11991jonathanpeppers with Copilot wants to merge 3 commits into
Conversation
7 tasks
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Enable nullable reference types in ItemWithID.cs
[nullable] Enable nullable reference types in Jul 6, 2026
ItemWithID.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ItemWithID.cswas compiling in a nullable-oblivious context. This opts it into#nullable enablewith the minimal mechanical changes required.Changes
src/Xamarin.Installer.AndroidSDK/Xamarin.Installer.AndroidSDK/Common/ItemWithID.cs#nullable enableafter the license header, beforeusingdirectivesEqualsparameters to match their interface/base signatures:No runtime behavior changes. The existing
if (other == null)guard already satisfies flow analysis; no!operator needed.