Skip to content

[nullable] Enable nullable reference types in ItemWithID.cs#11991

Draft
jonathanpeppers with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-finder-enable-nullable-reference-types
Draft

[nullable] Enable nullable reference types in ItemWithID.cs#11991
jonathanpeppers with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-finder-enable-nullable-reference-types

Conversation

Copilot AI commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

ItemWithID.cs was compiling in a nullable-oblivious context. This opts it into #nullable enable with the minimal mechanical changes required.

Changes

  • src/Xamarin.Installer.AndroidSDK/Xamarin.Installer.AndroidSDK/Common/ItemWithID.cs
    • Added #nullable enable after the license header, before using directives
    • Annotated Equals parameters to match their interface/base signatures:
      public bool Equals (ItemWithID? other)
      public override bool Equals (object? obj)

No runtime behavior changes. The existing if (other == null) guard already satisfies flow analysis; no ! operator needed.

Copilot AI and others added 2 commits July 6, 2026 03:00
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot AI changed the title [WIP] Enable nullable reference types in ItemWithID.cs [nullable] Enable nullable reference types in ItemWithID.cs Jul 6, 2026
Copilot AI requested a review from jonathanpeppers July 6, 2026 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[fix-finder] Enable nullable reference types in ItemWithID.cs

2 participants