Skip to content

fix: correct log placeholder kwarg for untriggered pipeline breakpoint warning#11885

Open
Kropiunig wants to merge 1 commit into
deepset-ai:mainfrom
Kropiunig:fix/breakpoint-log-placeholder
Open

fix: correct log placeholder kwarg for untriggered pipeline breakpoint warning#11885
Kropiunig wants to merge 1 commit into
deepset-ai:mainfrom
Kropiunig:fix/breakpoint-log-placeholder

Conversation

@Kropiunig

Copy link
Copy Markdown

The warning that fires when a pipeline breakpoint is never triggered used the placeholder {break_point} in its message, but passed the value under the kwarg pipeline_breakpoint. Haystack's logger catches the resulting KeyError from msg.format(**safe_extra) and falls back to the raw string, so users saw the literal text {break_point} instead of the actual breakpoint.

Renaming the kwarg to break_point so it matches the placeholder makes the message interpolate the real value. One-line change; the message string is unchanged.

@Kropiunig Kropiunig requested a review from a team as a code owner July 6, 2026 13:01
@Kropiunig Kropiunig requested review from davidsbatista and removed request for a team July 6, 2026 13:01
@vercel

vercel Bot commented Jul 6, 2026

Copy link
Copy Markdown

@Kropiunig is attempting to deploy a commit to the deepset Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vercel

vercel Bot commented Jul 6, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
haystack-docs Ignored Ignored Preview Jul 6, 2026 1:16pm

Request Review

@davidsbatista

Copy link
Copy Markdown
Contributor

Hi @Kropiunig - can you please sign the CLA?

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  haystack/core/pipeline
  async_pipeline.py
  pipeline.py
Project Total  

This report was generated by python-coverage-comment-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants