🔨 Large internal refactor / file management#171
Merged
Conversation
🦋 Changeset detectedLatest commit: 0c096da The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
danieldelcore
force-pushed
the
refactor-main
branch
from
869f919 to
4daecd5
Compare
Contributor
|
@danieldelcore: Nice one. When I went through the code few months back (for fixing a bug), I was totally lost. Some files are crossing 1000 lines. If possible we can split it into multiple files based on their responsibilities. |
danieldelcore
changed the title
Collaborator
Author
|
It's a BEAST |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been finding the source code hard to understand and a little bit confusing lately. This pr tries to separate the index.js file into separate, more focused files to help reduce the noise.
index.js= entry points, API of the packageexport-manager.js= responsible for finding and handling exportsconverter.js= contains all of the converter logickinds.js= flow typings for supported "kinds"