fix(tui): settle stale replay work#35693
Open
fengjikui wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
Bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Fixes #35642
Type of change
What does this PR do?
When the TUI replays a session after reconnect/restart, it now checks
session.status()before treating replayed active parts as still running. If the session is not busy/retrying, replay flushes stale active text/tool entries as interrupted instead of leaving spinners and the running footer active.If the session is still busy/retrying, replay keeps those parts active so attaching to real background work still behaves normally.
This is scoped to the concrete TUI replay symptom. The broader durable core recovery contract remains tracked in #35467.
How did you verify your code works?
bun test src/cli/cmd/run/session-replay.test.tsbun test src/cli/cmd/runbun typecheckfrompackages/opencodebunx prettier --check src/cli/cmd/run/session-data.ts src/cli/cmd/run/session-replay.ts src/cli/cmd/run/session-replay.test.ts src/cli/cmd/run/stream.transport.tsbunx oxlint packages/opencode/src/cli/cmd/run/session-data.ts packages/opencode/src/cli/cmd/run/session-replay.ts packages/opencode/src/cli/cmd/run/session-replay.test.ts packages/opencode/src/cli/cmd/run/stream.transport.ts(0 errors; existing warnings instream.transport.ts)bun turbo typecheck(30/30 tasks successful)Screenshots / recordings
Not included; this is replay-state logic covered by the regression test.
Checklist