fix(app): guard missing notification server state#35688
Open
jones wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #35686
Type of change
What does this PR do?
Prevents the app notification context from crashing the renderer when notification state is requested for a server key that is not present in the current server list.
I hit this in OpenCode Desktop v1.17.14 on macOS. After startup, the app entered an infinite crash loop with:
Restart and Reload Webview did not clear it; the same error returned on the next launch. The IP address is an OpenCode server on my local network, and I can connect to it normally.
The crash started after a hard reset on macOS 27.0 beta. The entire macOS UI froze, so I forced a restart. After that, OpenCode Desktop was stuck showing this startup error and could not be used.
This change makes missing notification server state degrade to an empty/no-op notification state instead of throwing during render. Notification badges may be absent for that stale server key, but the app remains usable.
How did you verify your code works?
Ran:
Both passed from
packages/app.Screenshots / recordings
Before:
Checklist