fix(glob): enforce permissions on matched files#35683
Open
fengjikui wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Related PR Found#35682 - This is a closely related PR that applies the same permission enforcement pattern to the |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #35684
Related to #29674, but scoped only to glob result-path permission enforcement.
Type of change
What does this PR do?
globpreviously asked permission only for the requested glob pattern. If that broad pattern was allowed, path-scoped deny rules never saw the files returned by ripgrep, so denied paths could still appear in the tool output.This PR keeps the existing pattern permission check and adds a second permission check for the unique worktree-relative matched file paths before formatting results.
This is a narrow result-path permission fix and does not change wildcard matching semantics.
How did you verify your code works?
bun test --timeout 30000 test/tool/glob.test.tsbun test --timeout 30000 test/tool/glob.test.ts test/tool/grep.test.ts test/tool/read.test.ts test/permission/next.test.tsbun test --timeout 30000 test/toolbun typecheckfrompackages/opencodebunx prettier --check packages/opencode/src/tool/glob.ts packages/opencode/test/tool/glob.test.tsgit diff --checkbun run lint(passes with existing warnings, 0 errors)bun turbo typecheck(30/30 tasks passed)Screenshots / recordings
Not a UI change.
Checklist