Skip to content

Remove pcfsoft shadow type, deprecated in r182, pcf is now soft as well#5798

Merged
dmarcos merged 1 commit into
aframevr:masterfrom
vincentfretin:remove-pcfsoft
May 21, 2026
Merged

Remove pcfsoft shadow type, deprecated in r182, pcf is now soft as well#5798
dmarcos merged 1 commit into
aframevr:masterfrom
vincentfretin:remove-pcfsoft

Conversation

@vincentfretin

Copy link
Copy Markdown
Contributor

Description:

Remove pcfsoft shadow type, deprecated in r182, pcf is now soft as well.
You should wait for three to be updated to r182+ before merging this.

Changes proposed:

  • Remove pcfsoft from the available shadow types
  • Change pcfsoft to pcf in the docs and examples
  • Add migration guide in changelog

@mrxz

mrxz commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Perhaps we can add a generic fallback in shadow#init for when the given shadow type isn't known. That should more gracefully handle any mistyped/unknown types and has the added benefit of not breaking when users upgrade, while a warning in the console can still clue them in to change/fix it.

@vincentfretin

vincentfretin commented Mar 30, 2026

Copy link
Copy Markdown
Contributor Author

Right, the warning on threejs side THREE.WebGLShadowMap: PCFSoftShadowMap has been deprecated. Using PCFShadowMap instead..
I propose shadow type "pcfsoft" is not supported, falling back to "pcf". To remove this warning set <a-scene shadow="type: pcf">.
I did the change.

…ll, show a warning about shadow type not supported and fall back to pcf
@dmarcos dmarcos merged commit c7c28cc into aframevr:master May 21, 2026
1 check passed
@vincentfretin vincentfretin deleted the remove-pcfsoft branch May 22, 2026 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants