chore: add playwright smoke tests setup#6366
Conversation
|
Important Review skippedToo many files! This PR contains 838 files, which is 688 over the limit of 150. To get a review, narrow the scope: Upgrade to a paid plan to raise the limit. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (838)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
View your CI Pipeline Execution ↗ for commit 10eea28
☁️ Nx Cloud last updated this comment at |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
There was a problem hiding this comment.
Important
At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.
Nx Cloud is proposing a fix for your failed CI:
We removed @angular/platform-browser from packages/angular-table-devtools/package.json devDependencies to fix the table:test:knip failure. This package was added by the PR but is not imported or referenced anywhere in the angular-table-devtools source, causing knip to flag it as an unused devDependency and exit with code 1. Removing it resolves the check while keeping the legitimately needed @angular/compiler and @angular/core entries intact.
Warning
❌ We could not verify this fix.
diff --git a/packages/angular-table-devtools/package.json b/packages/angular-table-devtools/package.json
index d3988c68..7fd34db6 100644
--- a/packages/angular-table-devtools/package.json
+++ b/packages/angular-table-devtools/package.json
@@ -53,7 +53,6 @@
},
"devDependencies": {
"@angular/compiler": "^22.0.2",
- "@angular/core": "^22.0.2",
- "@angular/platform-browser": "^22.0.2"
+ "@angular/core": "^22.0.2"
}
}
Or Apply changes locally with:
npx nx-cloud apply-locally tZ3Q-PpMI
Apply fix locally with your editor ↗ View interactive diff ↗
🎓 Learn more about Self-Healing CI on nx.dev
🎯 Changes
✅ Checklist
pnpm test:pr.