[libcu++] Reformulate tuple constraints to reduce memory consumption#9703
[libcu++] Reformulate tuple constraints to reduce memory consumption#9703miscco wants to merge 6 commits into
Conversation
1658ed7 to
337de0d
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughRefactors ChangesConstraint helper consolidation
Possibly related PRs
Suggested reviewers: Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 4c466d95-6165-453f-b6a7-3687fce8e2cf
📒 Files selected for processing (3)
libcudacxx/include/cuda/std/__tuple_dir/tuple.hlibcudacxx/include/cuda/std/__tuple_dir/tuple_constraints.hlibcudacxx/include/cuda/std/__utility/pair.h
We are experiencing memory consumption issues recently. One of the major changes was a rewrite of tuple constraints to support the new tuple like constructors. This refactors the machinery to be closer to what we had previously in hopes it reduces the memory consumption
337de0d to
e5c252f
Compare
😬 CI Workflow Results🟥 Finished in 4h 31m: Pass: 67%/120 | Total: 6d 16h | Max: 4h 30m | Hits: 39%/1303459See results here. |
We are experiencing memory consumption issues recently. One of the major changes was a rewrite of tuple constraints to support the new tuple like constructors.
This refactors the machinery to be closer to what we had previously in hopes it reduces the memory consumption